Add explicit getters for TimelockAuthorizer #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
requested changes
May 19, 2022
TomAFrench
added a commit
that referenced
this pull request
May 26, 2022
* master: (76 commits) Reuse swap fee code; add startWeights to weight update params for symmetry with swap fee update params (#1324) Ensure that global permissions are properly transferred along with root status. (#1319) Move up require to save gas on add token validation failure (#1318) Stop migrating role-admins (#1321) Managed Pools: Consistent LP allowlist behavior (#1322) Only allow root to create new granters or revokers (#1313) Only allow root to schedule a change to a delay (#1314) Switch to a two step process to migrate the root account of the Authorizer (#1316) Add optional key argument to verify-contract Add explicit getters for TimelockAuthorizer (#1298) Update Authorizer tests (#1299) fix: stop storing deployment transactions for fork test deployments (#1311) Automatically save the deployment tx hash on deployment (#1310) Update SNX impl input (#1309) Add implementation + deployment of the ProtocolFeesWithdrawer (#1301) minor update for consistency (#1306) fix: fix fork test for NoProtocolFeeLBP (#1304) ci: switch from infura to alchemy (#1305) Check deployment outputs (#1284) fix: use force argument in no fee LBP task (#1303) ...
dandamiangow3t
pushed a commit
to IlluviumGame/balancer-v2-monorepo
that referenced
this pull request
May 10, 2023
* refactor: make root storage variable private * refactor: make `delayerPerActionId` storage variable private * refactor: make scheduledExecutions storage variable private * refactor: make isPermissionGranted storage variable private * refactor: use getRootTransferDelay getter rather than using variable directly * refactor: rename isPermissionGranted to isPermissionGrantedOnTarget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces any public state variables with private versions and a getter.
One question this raises is whether we want to be more careful about potential confusion between
isPermissionGrantedandhasPermission(I've added some natspec on this). One option is to not expose theisPermissionGrantedgetter but this would cause confusion when trying to figure out if someone's permission is local or global.